Skip to content
This repository was archived by the owner on Jan 26, 2025. It is now read-only.

chore[oidc-middleware]: Updating UUID version - #1010

Open
NovaAtWarren wants to merge 4 commits into
okta:masterfrom
NovaAtWarren:patch-2
Open

chore[oidc-middleware]: Updating UUID version#1010
NovaAtWarren wants to merge 4 commits into
okta:masterfrom
NovaAtWarren:patch-2

Conversation

@NovaAtWarren

@NovaAtWarren NovaAtWarren commented Jun 15, 2021

Copy link
Copy Markdown
Contributor

Avoids this error message: Older versions may use Math.random() in certain circumstances, which is known to be problematic. See https://v8.dev/blog/math-random for details.
Potential security upgrade.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Adding Tests
  • Build related changes
  • CI related changes
  • Documentation changes
  • Other: Dependency Update

What is the current behavior?

N/A
Issue Number: N/A

What is the new behavior?

N/A

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Reviewers

@NovaAtWarren
chore[oidc-middleware]: Updating UUID version
948f495 
Avoids deprecation message and insecure random usages
@oleksandrpravosudko-okta

oleksandrpravosudko-okta commented Jun 15, 2021

Copy link
Copy Markdown
Contributor

Thanks for the contribution @NovaAtWarren.
Would you mind pushing yarn.lock update as well? (it looks like Travis build is failing because of missing lock file update)

@NovaAtWarren

NovaAtWarren commented Jun 15, 2021

Copy link
Copy Markdown
Contributor Author

Thanks for the contribution @NovaAtWarren.
Would you mind pushing yarn.lock update as well? (it looks like Travis build is failing because of missing lock file update)

Seems to me like a linting error in src/logout.js. Would you like me to change code to attempt a fix, or disable that linting rule for that line?

@NovaAtWarren

NovaAtWarren commented Jun 15, 2021

Copy link
Copy Markdown
Contributor Author

Finally, a package with proper SemVer. Bad side is this seems to have broken more than I initially thought. I'll have a closer look when I'm in front of a machine with a proper debugger.

@Not-Super-Nova
fix[oidc-middleware]: Fixed UUID returning null value
dc44e5b 
Caused by update without reading migration guide.
Test > e2e > harness > server.js > DemoServer > start now uses random UUID like it used to.
@Not-Super-Nova
refactor[oidc-middleware]: Replaced Promise.reject with throw
798a594 
Fixed error in linting where eslint complained about using Promise.reject. This should function the same, without the error while linting
@NovaAtWarren

NovaAtWarren commented Jun 15, 2021

Copy link
Copy Markdown
Contributor Author

Build now failing with Failed: Replace {clientSecret} with the client secret of your Application. You can copy it from the Okta Developer Console in the details for the Application you created. Follow these instructions to find it: https://bit.ly/finding-okta-app-credentials, and I don't have the testing client secret so I can't really do anything

@shuowu

shuowu commented Jun 15, 2021

Copy link
Copy Markdown
Contributor

@NovaAtWarren Thanks for your contribution. Since the PR need to pass Okta's internal CI system to get merged. We'll take over your PR at this point, and fix issues accordingly if needed.

Internal Ref: OKTA-404546

@aarongranick-okta aarongranick-okta mentioned this pull request Jun 30, 2021
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@NovaAtWarren @oleksandrpravosudko-okta @shuowu @Not-Super-Nova